add logging when a request is being cancelled #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can more easily see (especially for to_device requests) why something was cancelled
jryans
approved these changes
Feb 4, 2020
| // requests on its own | ||
| if (type === CANCEL_TYPE) { | ||
| logger.log(`verification request ${this.channel.transactionId}: ` + | ||
| `.cancel event with ${JSON.stringify(event.getContent())} ` + |
There was a problem hiding this comment.
Maybe pass this as a separate not-stringifed arg so it's easier to inspect in the console?
There was a problem hiding this comment.
logger.log doesn't support multiple arguments I think? Also, if it did/does, I'm not sure how that would appear in the logs sent through rageshakes. Not [Object object] or something?
There was a problem hiding this comment.
Fine to merge either way. console.log definitely does, so we might want to change the logger in some other PR. Rageshakes already stringify where needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can more easily see (especially for to_device requests)
why something was cancelled, to debug issues like element-hq/element-web#12226