Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option to fully reset Secret Storage keys in boostrapSecretStorage #1202

Merged
merged 2 commits into from
Feb 10, 2020
Merged

New option to fully reset Secret Storage keys in boostrapSecretStorage #1202

merged 2 commits into from
Feb 10, 2020

Conversation

foldleft
Copy link
Contributor

@foldleft foldleft commented Feb 7, 2020

@foldleft foldleft requested a review from a team February 7, 2020 14:45
turt2live
turt2live approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a code perspective - do we not want to log when this happens?

src/crypto/index.js Outdated Show resolved Hide resolved
@foldleft foldleft merged commit d66d4c1 into develop Feb 10, 2020
@foldleft foldleft deleted the foldleft/12221-reset-cross-signing branch February 10, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foldleft @turt2live