Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store USK and SSK locally #1235

Merged
merged 7 commits into from
Mar 2, 2020
Merged

Store USK and SSK locally #1235

merged 7 commits into from
Mar 2, 2020

Conversation

foldleft
Copy link
Contributor

@foldleft foldleft commented Feb 27, 2020

fixes: element-hq/element-web#12299

Testing:
Do a verification
mxMatrixClientPeg.get()._crypto._crossSigningInfo._cacheCallbacks.getCrossSigningKeyCache("user_signing").then(console.log.bind(console))

@foldleft foldleft requested a review from a team February 27, 2020 16:42
@turt2live
Copy link
Member

Presuming this is ready for review

@turt2live turt2live marked this pull request as ready for review February 27, 2020 23:18
spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
src/crypto/store/memory-crypto-store.js Outdated Show resolved Hide resolved
@foldleft foldleft requested review from turt2live and a team February 28, 2020 11:06
@foldleft
Copy link
Contributor Author

I'm wondering if I should have been using getFromSecretStorage etc for this

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise seems fine, though I'm not a crypto expert

spec/unit/crypto/CrossSigningInfo.spec.js Outdated Show resolved Hide resolved
@foldleft foldleft merged commit a4ed3d9 into develop Mar 2, 2020
@foldleft foldleft deleted the foldleft/12299-local-ssk branch March 2, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store USK and SSK locally
2 participants