Upload only new device signature of master key #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes bootstrap to only upload the new device signature of the master key. We were previously _adding_ the new signature, but then uploading both old and new device key signatures of the master key. This was particularly bad when re-uploading signatures from deleted devices, as that would cause the homeserver to reject the entire upload. Fixes element-hq/element-web#12752
dbkr
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes bootstrap to only upload the new device signature of the master
key. We were previously adding the new signature, but then uploading both old
and new device key signatures of the master key.
This was particularly bad when re-uploading signatures from deleted devices, as
that would cause the homeserver to reject the entire upload.
Fixes element-hq/element-web#12752