Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for checking cross-signing is ready #1279

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 23, 2020

Aggregate function that checks the various things are in place for
cross-signing to work.

Aggregate function that checks the various things are in place for
cross-signing to work.
@dbkr dbkr requested a review from a team March 23, 2020 18:36
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this pull request Mar 23, 2020
Fixes mismatches where the Cross signing panel would say cross
signing was not ready but no toasts would appear.

Fixes element-hq/element-web#12796
Fixes element-hq/element-web#12798
Requires matrix-org/matrix-js-sdk#1279
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this look good overall!

src/crypto/index.js Outdated Show resolved Hide resolved
dbkr and others added 2 commits March 24, 2020 13:00
@dbkr dbkr merged commit 42efdf1 into develop Mar 24, 2020
@t3chguy t3chguy deleted the dbkr/unify_cross_signing_checks branch May 10, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants