Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track whether we have verified a user before #1292

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Mar 30, 2020

This tracks whether we have ever cross-signing verified a user before (at least
as far as the current device has ever observed). This info helps to present an
alert in case the user subsequently becomes unverified.

Part of element-hq/element-web#12808
Used by matrix-org/matrix-react-sdk#4303

This tracks whether we have ever cross-signing verified a user before (at least
as far as the current device has ever observed). This info helps to present an
alert in case the user subsequently becomes unverified.

Part of element-hq/element-web#12808
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the flag is persisted somewhere.

If it isn't supposed to be persisted somewhere, can we change the docs to mention that it's the lifetime of the memory?

If it is supposed to be persisted somewhere, I probably just missed where that's happening.

@jryans
Copy link
Collaborator Author

jryans commented Mar 31, 2020

If it is supposed to be persisted somewhere, I probably just missed where that's happening.

It's maybe not so obvious at a glance... This patch updates the raw cross-signing data in the device list, which is persisted to IDB.

@jryans jryans merged commit 6343da3 into develop Mar 31, 2020
@t3chguy t3chguy deleted the jryans/id-change-red branch May 10, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants