Fix: handle filter not found #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made getFilter in sync retrying continuously I also refactored getOrCreateFilter to use await
this way we don't attempt to fetch filters when validating them with filterId==="undefined"
dbkr
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The not-found scenario was broken, as the server returns status code 400 instead of 404. This was not triggered before, but since #1332 it did, because the deep comparison failed because limit is now set on the filter. This caused "undefined" to be stored in the store, triggering the not-found scenario on reload.
While at it I rewrote
getOrCreateFilterto useawaitrather than chainingthen(...).Please also review release PR at #1341