Remove support for asymmetric 4S encryption #1373
Conversation
bwindels
force-pushed
the
bwindels/remove-asym-4s
branch
from
02890c1
to
bc32faf
Compare
| @@ -1310,7 +1310,6 @@ wrapCryptoFuncs(MatrixClient, [ | |||
| "bootstrapSecretStorage", | |||
| "addSecretStorageKey", | |||
| "hasSecretStorageKey", | |||
| "secretStorageKeyNeedsUpgrade", | |||
There was a problem hiding this comment.
Maybe should keep this in order to not break backwards compat, but just have it return false.
There was a problem hiding this comment.
I'd rather remove it and mark this as a breaking change tbh. There will likely be more breaking changes coming anyway when disentangling 4S and cross-signing. Will add this in the PR description 👍
There was a problem hiding this comment.
About breaking changes, we've been marking 4S / cross-signing APIs in client.js with the text "The Secure Secret Storage API is currently UNSTABLE and may change without notice.", so I think that may be enough wiggle room to make breaking changes like this without a major version bump.
There was a problem hiding this comment.
Filed element-hq/element-web#13651 to track properly stabilising these APIs.
bwindels
force-pushed
the
bwindels/remove-asym-4s
branch
from
2380bf2
to
7b173f4
Compare
|
Sorry, had to force-push because I pushed a WIP commit for the next phase by accident. The only thing I changed was bringing back the algorithm parameter. |
Removes support for Curve25519 encryption of SSSS secrets. Also removes signing of the SSSS key by the cross-signing master key, as that is not needed for AES encryption.
This is a breaking change, as it removes the
secretStorageKeyNeedsUpgrademethod onMatrixClient.Part of element-hq/element-web#13581
Required by matrix-org/matrix-react-sdk#4581