[BREAKING] Convert RoomState's stored state map to a real map #1419
Conversation
Though the dictionary format works fine, it's slow. Access times are around the 1ms range for rooms like HQ, which doesn't seem like much, but when compared to the Map's access time of 0.05ms it's slow. Converting things to a map means we lose index access and have to instead use `.keys()` and `.values()`, both of which return iterables and not arrays. Even doing the `Array.from()` conversion we see times in the 0.05ms range. This is also what makes this a breaking change. Memory-wise there does not appear to be any measurable impact for a large account.
|
As an interesting bit of testing: |
That's quite surprising...! 😱 Definitely would have expected |
|
@turt2live Which part is so high risk about this...? The late-breaking change to APIs? |
|
It's high risk because I can't guarantee that I've caught all the places we use the public property. A combination of being 2016-era JS and generically named means there's huge potential that a reference was missed. |
Requires matrix-org/matrix-react-sdk#4936
We probably do not want to land this until after an RC as it is very high risk.
Though the dictionary format works fine, it's slow. Access times are around the 1ms range for rooms like HQ, which doesn't seem like much, but when compared to the Map's access time of 0.05ms it's slow.
Converting things to a map means we lose index access and have to instead use
.keys()and.values(), both of which return iterables and not arrays. Even doing theArray.from()conversion we see times in the 0.05ms range. This is also what makes this a breaking change.Memory-wise there does not appear to be any measurable impact for a large account.