Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer doc for setRoomDirectoryVisibility #144

Merged
merged 2 commits into from
Jun 22, 2016
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 22, 2016

No description provided.

@@ -2186,7 +2186,8 @@ MatrixClient.prototype.getRoomDirectoryVisibility =
/**
* Set the visbility of a room in the current HS's room directory
* @param {string} roomId
* @param {string} visibility
* @param {string} "public" to make the room visible in the public directory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs visibility

@richvdh
Copy link
Member

richvdh commented Jun 22, 2016

lgtm otherwise

@richvdh richvdh closed this Jun 22, 2016
@richvdh richvdh reopened this Jun 22, 2016
@richvdh richvdh assigned dbkr and unassigned richvdh Jun 22, 2016
@dbkr dbkr assigned richvdh and unassigned dbkr Jun 22, 2016
@richvdh richvdh merged commit 7ff1cf4 into develop Jun 22, 2016
@t3chguy t3chguy deleted the dbkr/set_visibility_doc branch May 10, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants