Add method to check whether client .well-known has been fetched #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows clearly detecting whether we have _ever_ fetched .well-known at all. Without this, it's hard to be sure whether the value is `undefined` because the fetch has not been attempted yet or because an error occurred.
dbkr
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Hmm, I wonder if a method that returns a promise that resolves with the well known result or null once it's been fetched or failed to fetch, respectively, might be simpler?
This also seems fine though, although I would add a this._clientWellKnownFetchAttempted = false; to the constructor so it returns false rather than undefined (and maybe add similar for the other members too, eg. this._clientWellKnown, even though it's been baked into the API that it returns undefined rather than null...)
|
@dbkr I have switched to a promise-based API, let me know how it looks now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clearly detecting whether we have ever fetched .well-known at all.
Without this, it's hard to be sure whether the value is
undefinedbecause thefetch has not been attempted yet or because an error occurred.
Part of element-hq/element-web#14954
Used by matrix-org/matrix-react-sdk#5130