Repair secret storage reset, cache keys when missing #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures we omit any uncached keys, rather than adding nulls. This is helpful for future steps that might try to store all of the values in one call. Fixes element-hq/element-web#15230
We were only caching private keys locally on public key change, but we should also do so if they are missing from the current session: e.g. for most users that will be true for the master key, since previously we were not caching it. Part of element-hq/element-web#15230
jryans
added a commit
that referenced
this pull request
Mar 23, 2021
This is a revised version of #1472 which was previously reverted for caused security prompts to appear on device list sync. In this version, we only allow private key requests (which are likely to trigger user dialogs) if we are coming from the bootstrap path. This allows sessions that have already synced cross-signing public keys but never got the private keys for some reason to make forward progress when e.g. the user triggers bootstrap from security settings.
jryans
added a commit
that referenced
this pull request
Mar 24, 2021
This is a revised version of #1472 which was previously reverted for causing security prompts to appear on device list sync. In this version, we only allow private key requests (which are likely to trigger user dialogs) if we are coming from the bootstrap path. This allows sessions that have already synced cross-signing public keys but never got the private keys for some reason to make forward progress when e.g. the user triggers bootstrap from security settings.
jryans
added a commit
that referenced
this pull request
Mar 26, 2021
This removes some catch blocks originally added by #1472 so that higher level operations can handle them as needed. Part of element-hq/element-web#15584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to avoid an error when resetting if secret storage if you only have some but not all cross-signing keys. It also changes the path for caching from secret storage so it will try to cache private keys whenever they are missing as well as on private key change.
Fixes element-hq/element-web#15230