Convert call.js to Typescript & update WebRTC APIs #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a fairly basic rewriting of the whole file to bring it up to a vaguely modern standard of code. Nothing should have changed fundamentally, but it probably should do: as per the global type overrides, we use a lot of deprecated WebRTC APIs and should probably update.
Various flags that may or may not have been part of the poorly defined external API before. Neither were used internally. Make direction a public export but remove didConnect.
and some other related & semi-related refactoring
Otherwise we end up with separate, unbundled 'streamless tracks' which is not what we want.
As per comment, this seems to be the way to make setSinkId work reliably on Chrome. Also don't make our own mediastreams if we don't need to (ie. in a normal call our tracks should come with their owen MediaStreams).
dbkr
changed the title
t3chguy
reviewed
Oct 6, 2020
t3chguy
reviewed
Oct 6, 2020
t3chguy
approved these changes
Oct 6, 2020
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two large commits here: a78b590 which converts to typescript and cc4656b which updates to changes in the WebRTC API (mostly using promises instead of callbacks and not using
addStream().This PR also should make the output setting a bit more reliable, as this appears to be quite sensitive on Chrome (it's still not implemented on Firefox).