Support global account_data #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Set account data event for the current user. | ||
| * @param {string} eventType The event type | ||
| * @param {Object} the contents object for the event |
There was a problem hiding this comment.
For JSDoc to pick it up sanely, the thing after the type has to be the variable name, hence this should be:
* @param {Object} contents the object for the event
|
Overall, beautiful :) just needs some clarification on docs. |
|
@kegsay: PTAL |
|
LGTM |
| @@ -4001,6 +4015,17 @@ module.exports.CRYPTO_ENABLED = CRYPTO_ENABLED; | |||
| * @param {module:client~DeviceInfo} device information about the verified device | |||
| */ | |||
|
|
|||
| /** | |||
| * Fires whenever new user-scoped account_data is added. | |||
| * @event module:client~MatrixClient#"Room" | |||
There was a problem hiding this comment.
should this be module:client~MatrixClient#"accountData" ?
There was a problem hiding this comment.
Bah didn't spot that! Yes it should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.