/login, /register: Add device_id and initial_device_display_name #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help test the forthcoming device_id support for /login and /register, add the device_id and initial_device_display_name parameters to those calls. Allow the app to specify the default device displayname when creating the client (as well as the device_id). Also, don't try initialising the Olm layer unless a userId is provided. Currently this isn't a problem because react-sdk doesn't provide a sessionStore when it doesn't provide a userId, but that is a bad thing to rely on (and I am going to break it with a react-sdk PR).
This was referenced Jul 20, 2016
| }; | ||
|
|
||
| // merge data into login_data | ||
| for (var k in data) { |
There was a problem hiding this comment.
I believe you can now use for...of to avoid having to do the hasownProperty mess
Edit: except of course this is the JS SDK which is ES5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help test the forthcoming device_id support for /login and /register, add
the device_id and initial_device_display_name parameters to those calls. Allow
the app to specify the default device displayname when creating the client (as
well as the device_id).
Also, don't try initialising the Olm layer unless a userId is
provided. Currently this isn't a problem because react-sdk doesn't provide a
sessionStore when it doesn't provide a userId, but that is a bad thing to rely
on (and I am going to break it with a react-sdk PR).