Convert call test to TypeScript #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start the migration to v1 VoIP by supporting m.call.reject, which we'll send if the caller says they're v1. Our version stays as v0 for now, until we speak the rest of v1. Honour the default reaosn in a hangup being user_hangup.
Send party_id on events and check the party_id of incoming events matches Includes a basic test to assert that it actually does: we should build out a decent test suite for calls as there's a lot of edge-case functionality that can break and slip through the cracks (eg. glare). This is a start. Fixes #1511
Typescript tests basically just appear to work, apart from needing the jest types imported so the typescript checker knows what's what. DConvert the webrtc test to typescript, which actually mostly just serves to point out that we're not mocking the whole of `document`, but oh well.
turt2live
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript tests basically just appear to work, apart from needing
the jest types imported so the typescript checker knows what's what.
Convert the webrtc test to typescript, which actually mostly just
serves to point out that we're not mocking the whole of
document,but oh well.
Based on: #1512 (pull/1512/head...pull/1516/head)