Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client set profile methods update own user #1534

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Client set profile methods update own user #1534

merged 4 commits into from
Nov 4, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 2, 2020 •
edited
Loading

Synthesise profile updates for ourselves to work around issues when you are in 0 rooms.

@t3chguy t3chguy requested a review from a team November 2, 2020 17:42
@t3chguy t3chguy mentioned this pull request Nov 2, 2020
Merged
turt2live
turt2live requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear from the PR what this is trying to accomplish - can we get a description, issue link, or something that says why we need to manipulate the user object directly?

src/client.js Outdated Show resolved Hide resolved
src/client.js Outdated Show resolved Hide resolved
turt2live
turt2live approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

@t3chguy t3chguy merged commit f11103b into develop Nov 4, 2020
@t3chguy t3chguy deleted the t3chguy/fix/15604 branch November 4, 2020 14:00
marceltransier pushed a commit to marceltransier/matrix-js-sdk that referenced this pull request Nov 20, 2020
Merge tag 'v9.2.0-rc.1' into force_user_status
b95b96d 
[Full Changelog](matrix-org/matrix-js-sdk@v9.1.0...v9.2.0-rc.1)
* Implement call holding functionality
[\matrix-org#1532](matrix-org#1532)
* Support awaitable one-time dehydration
[\matrix-org#1537](matrix-org#1537)
* Client set profile methods update own user
[\matrix-org#1534](matrix-org#1534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @turt2live