Don't log error when environment does not support WebRTC #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Nov 26, 2020
src/webrtc/call.ts
Outdated
| @@ -1569,7 +1569,7 @@ export function setVideoInput(deviceId: string) { videoInput = deviceId; } | |||
| export function createNewMatrixCall(client: any, roomId: string, options?: CallOpts) { | |||
| // typeof prevents Node from erroring on an undefined reference | |||
| if (typeof(window) === 'undefined' || typeof(document) === 'undefined') { | |||
| logger.error("No window or document object: WebRTC is not supported in this environement"); | |||
| logger.info("No window or document object: WebRTC is not supported in this environement"); | |||
There was a problem hiding this comment.
while we're here:
Suggested change
| logger.info("No window or document object: WebRTC is not supported in this environement"); | |
| logger.info("No window or document object: WebRTC is not supported in this environment"); |
This function is *always* called when a MatrixClient is created, e.g. in an appservice. If the environment does not support WebRTC, this is not necessarily an error; it is expected in many situations. Fix a small typo Signed-off-by: Dexter Chua <[email protected]>
|
Fixed
|
jryans
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is always called when a MatrixClient is created, e.g. in
an appservice. If the environment does not support WebRTC, this is not
necessarily an error; it is expected in many situations.