Don't log if no WebRTC #1574
Merged
Don't log if no WebRTC #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as hopefully explained in comment
t3chguy
approved these changes
Jan 12, 2021
| @@ -1663,7 +1663,8 @@ export function setVideoInput(deviceId: string) { videoInput = deviceId; } | |||
| export function createNewMatrixCall(client: any, roomId: string, options?: CallOpts) { | |||
| // typeof prevents Node from erroring on an undefined reference | |||
| if (typeof(window) === 'undefined' || typeof(document) === 'undefined') { | |||
| logger.info("No window or document object: WebRTC is not supported in this environment"); | |||
| // NB. We don't log here as apps try to create a call object as a test for | |||
There was a problem hiding this comment.
I was going to suggest using console.debug to hide it in typical envs only to find out that console.debug is an alias for console.log in Node :'(
There was a problem hiding this comment.
Oh but we're not even using bare console, but we set up loglevel with DEBUG on - so either way no bueno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as hopefully explained in comment