Migrate to eslint-plugin-matrix-org
#1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
force-pushed
the
jryans/rework-linting
branch
from
11b077e
to
e7708c0
Compare
turt2live
reviewed
Mar 16, 2021
| "babel-jest": "^26.6.3", | ||
| "babelify": "^10.0.0", | ||
| "better-docs": "^2.3.2", | ||
| "browserify": "^17.0.0", | ||
| "docdash": "^1.2.0", | ||
| "eslint": "7.18.0", | ||
| "eslint-config-matrix-org": "^0.2.0", | ||
| "eslint-plugin-babel": "^5.3.1", | ||
| "eslint-config-google": "^0.14.0", |
There was a problem hiding this comment.
hmm, why are we pulling in the google config here?
There was a problem hiding this comment.
Our configs extend from it, and since I've removed all the deps from our own package, it appears here.
jryans
commented
Mar 22, 2021
|
Thanks! I think I'll hold onto this for a moment, until I can come back around and make the same changes in the other repos, as that's likely less confusing... |
jryans
force-pushed
the
jryans/rework-linting
branch
from
e7708c0
to
1268e73
Compare
|
Well, I should have expected the React SDK side would turn into a much larger dance... I'll get this one updated so it can merge. |
This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
jryans
force-pushed
the
jryans/rework-linting
branch
from
1268e73
to
102704e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
Related to element-hq/element-web#16276
Depends on matrix-org/eslint-plugin-matrix-org#5