Implement megolm encryption/decryption #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very early attempt at encryption/decryption implementation via megolm. You have to c&p the keys manually.
| sender_key: this._olmDevice.deviceCurve25519Key, | ||
| body: ciphertext, | ||
| session_id: this._outboundSessionId, | ||
| signature: "FIXME", |
There was a problem hiding this comment.
yup. I haven't implemented the signing bit yet. It can stay as FIXME as a reminder to us all ;)
There was a problem hiding this comment.
Maybe add a comment with a TODO? probably not worth it though. I think it's fairly obvious what needs to be done to fix it.
|
Otherwise LGTM. |
break long line into two statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early attempt at encryption/decryption implementation via megolm. You have
to c&p the keys manually.