Expose MatrixEvent's internal clearEvent as a function #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rr @t3chguy due to comment on the react-sdk side) |
t3chguy
reviewed
Jul 14, 2021
t3chguy
reviewed
Jul 14, 2021
| */ | ||
| public getEffectiveEvent(): IEvent { | ||
| // clearEvent doesn't have all the fields, so we'll copy what we can from this.event | ||
| return Object.assign({}, this.event, this.clearEvent) as IEvent; |
There was a problem hiding this comment.
are you allergic to the nicer syntax :P?
return {
...this.event,
...this.clearEvent,
}
There was a problem hiding this comment.
"nicer" - I feel it doesn't communicate the order properly given JS objects are unordered, so there's no implicit guarantee that the spread operation will be applied correctly. The spec says it will, but that's a detail someone has to remember when writing/reading the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#17615
For matrix-org/matrix-react-sdk#6371