Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to answer a call without video if we can't access the camera #1972

Merged
merged 6 commits into from
Oct 14, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 9, 2021

Fixes element-hq/element-web#17975
Type: enhancement


Here's what your changelog entry will look like:

✨ Features

@SimonBrandner SimonBrandner changed the title Try to answer a call without video if we can't the camera Try to answer a call without video if we can't access the camera Oct 9, 2021
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review October 10, 2021 06:32
@SimonBrandner SimonBrandner requested a review from a team as a code owner October 10, 2021 06:32
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this have a test?

@SimonBrandner
Copy link
Contributor Author

Could this have a test?

There probably is a way to somehow do this though I am not sure what is the best approach. I can give this a bit of time tomorrow, hopefully

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super - thank you!

@dbkr dbkr merged commit 6804e42 into matrix-org:develop Oct 14, 2021
@SimonBrandner SimonBrandner deleted the feature/answer-no-cam branch October 14, 2021 11:16
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Oct 25, 2021
* Use `ICallFeedOpts` in the `CallFeed` constructor. To construct a new `CallFeed` object you have to pass `ICallFeedOpts` e.g. `const callFeed = new CallFeed({client ([\matrix-org#1964](matrix-org#1964)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make threads use 'm.thread' relation ([\matrix-org#1980](matrix-org#1980)).
* Try to answer a call without video if we can't access the camera  ([\matrix-org#1972](matrix-org#1972)). Fixes element-hq/element-web#17975 and element-hq/element-web#17975. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make `opts` in `importRoomKeys()` optional ([\matrix-org#1974](matrix-org#1974)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Enable TypeScript declaration maps ([\matrix-org#1966](matrix-org#1966)). Contributed by [Alexendoo](https://github.com/Alexendoo).
* Fix `requestVerificationDM` with chronological `pendingEventOrdering` ([\matrix-org#1943](matrix-org#1943)). Contributed by [freaktechnik](https://github.com/freaktechnik).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Call doesn't hang up when camera is not available
3 participants