Send a 'm.new_device' when we get a message for an unknown group session #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the risk of a device getting permenantly stuck unable to receive encrypted group messages.
|
This feels a bit clunky in that the problematic message will still be dropped on the floor, even if subsequent ones are then okay. But it's better than it ending up stuck forever. LGTM. |
ara4n
reviewed
Sep 15, 2016
| } else { | ||
| // We've got a message for a session we don't have. | ||
| // Maybe the sender forgot to tell us about the session. | ||
| // Remind the sender that we exists so that they might |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the risk of a device getting permanently stuck unable
to receive encrypted group messages.
TODO: