Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ed25519 key checking #215

Merged
merged 4 commits into from
Sep 21, 2016
Merged

Fix the ed25519 key checking #215

merged 4 commits into from
Sep 21, 2016

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Sep 20, 2016

This completes the work Mark started in #206 on fixing element-hq/element-web#2215.

  • Include the Ed25519 key in all outgoing olm messages, including those used to establish megolm sessions.
  • In MatrixEvent, keep the claimed and proved keys as separate properties rather than stuffing them into _clearEvent
  • Make sure we store the claimed Ed25519 key correctly in the megolm sessions.

(Includes #214)

- a function to get information about the device which sent an event
This just makes the shape of the API a bit saner.
(including ones which just carry megolm keys)
Finish plumbing in the Ed25519 key checks. Make sure we store the claimed key
correctly in the megolm sessions, and keep them as a separate field in
MatrixEvent rather than stuffing them into _clearEvent
@dbkr dbkr removed their assignment Sep 21, 2016
@dbkr dbkr merged commit 14bc4af into develop Sep 21, 2016
@richvdh richvdh deleted the rav/key_proofs branch October 7, 2016 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants