Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in uploadContent() when file is empty under Node.js #2155

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented Feb 4, 2022


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix error in uploadContent() when file is empty under Node.js (#2155). Contributed by @hughns.

@hughns hughns added the T-Defect label Feb 4, 2022
@hughns hughns requested a review from a team as a code owner February 4, 2022 14:17
@hughns
Copy link
Member Author

hughns commented Feb 4, 2022

n.b. the proper fix for this is to replace request with a better behaving (and maintained) http client #801.

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@hughns hughns merged commit 25c1157 into develop Feb 11, 2022
@hughns hughns deleted the hughns/node-js-empty-content-upload branch February 11, 2022 11:16
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Mar 5, 2022
* Return send event response from MSC3089Branch.createNewVersion() ([\matrix-org#2186](matrix-org#2186)).
* Add functions to support refresh tokens ([\matrix-org#2178](matrix-org#2178)).
* [Release] Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2202](matrix-org#2202)).
* Fix bug where calls could break if rejected from somewhere else ([\matrix-org#2189](matrix-org#2189)).
* Fix camera stuck on after call transfer ([\matrix-org#2188](matrix-org#2188)).
* Fix synthetic read receipt handling ([\matrix-org#2174](matrix-org#2174)). Fixes element-hq/element-web#21016.
* Revert "Sign backup with cross-signing key when we reset it." ([\matrix-org#2175](matrix-org#2175)).
* Sign backup with cross-signing key when we reset it. ([\matrix-org#2170](matrix-org#2170)).
* Fix error in uploadContent() when file is empty under Node.js ([\matrix-org#2155](matrix-org#2155)).
* Check the backup info against the stored private key when determining trust. ([\matrix-org#2167](matrix-org#2167)).
* Back up keys before logging out ([\matrix-org#2158](matrix-org#2158)). Fixes element-hq/element-web#13151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants