Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message ordering in threads #2215

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Mar 3, 2022

Related to element-hq/element-web#21113
Related to element-hq/element-web#20914

  • Fix threads message ordering without server side support
  • Eagerly set thread instance on root event

This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #2215 (b70a581) into develop (6bc584b) will decrease coverage by 0.00%.
The diff coverage is 41.37%.

@@             Coverage Diff             @@
##           develop    #2215      +/-   ##
===========================================
- Coverage    57.61%   57.61%   -0.01%     
===========================================
  Files           90       90              
  Lines        16266    16269       +3     
  Branches      3742     3742              
===========================================
+ Hits          9372     9373       +1     
- Misses        6894     6896       +2     
Impacted Files Coverage Δ
src/models/room.ts 56.00% <0.00%> (ø)
src/models/thread.ts 38.01% <15.38%> (-0.32%) ⬇️
src/client.ts 34.74% <66.66%> (-0.03%) ⬇️
src/event-mapper.ts 94.11% <66.66%> (-5.89%) ⬇️
src/sync.ts 64.08% <80.00%> (ø)

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the PR title, you may wish to rebase this to get rid of the already-merged commits

@germain-gg germain-gg changed the title Make eventType optional for relations Fix message ordering in threads Mar 3, 2022
@germain-gg germain-gg merged commit fc5f0e8 into develop Mar 3, 2022
@germain-gg germain-gg deleted the gsouquet/threads-message-ordering branch March 3, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants