Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defer not supporting resolving with a Promise<T> #2216

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 3, 2022


Here's what your changelog entry will look like:

✨ Features

  • Fix defer not supporting resolving with a Promise (#2216).

@t3chguy t3chguy requested a review from a team as a code owner March 3, 2022 16:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #2216 (2c241a3) into develop (fc5f0e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2216   +/-   ##
========================================
  Coverage    57.61%   57.61%           
========================================
  Files           90       90           
  Lines        16269    16269           
  Branches      3742     3742           
========================================
  Hits          9373     9373           
  Misses        6896     6896           
Impacted Files Coverage Δ
src/utils.ts 89.50% <ø> (ø)

@t3chguy t3chguy merged commit 5d54bf5 into develop Mar 3, 2022
@t3chguy t3chguy deleted the t3chguy/fix/21290 branch March 3, 2022 21:41
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Mar 17, 2022
* Improve typing around event emitter handlers ([\matrix-org#2180](matrix-org#2180)).
* Fix defer not supporting resolving with a Promise<T> ([\matrix-org#2216](matrix-org#2216)).
* add LocationAssetType enum ([\matrix-org#2214](matrix-org#2214)).
* Support for mid-call devices changes ([\matrix-org#2154](matrix-org#2154)). Contributed by @SimonBrandner.
* Add new room state emit RoomStateEvent.Update for lower-frequency hits ([\matrix-org#2192](matrix-org#2192)).
* Fix wrong event_id being sent for m.in_reply_to of threads ([\matrix-org#2213](matrix-org#2213)).
* Fix wrongly asserting that PushRule::conditions is non-null ([\matrix-org#2217](matrix-org#2217)).
* Make createThread more resilient when missing rootEvent ([\matrix-org#2207](matrix-org#2207)). Fixes element-hq/element-web#21130.
* Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2201](matrix-org#2201)). Fixes element-hq/element-web#21170.
* fix relation sender filter ([\matrix-org#2196](matrix-org#2196)). Fixes element-hq/element-web#20877.
* Fix bug with one-way audio after a transfer ([\matrix-org#2193](matrix-org#2193)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants