Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for checking whether our other devices are cross-signed, even when this device isn't #2288

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Apr 8, 2022

This is something I'm now doing multiple different places in matrix-react-sdk, so I figured it was worth adding as a method on MatrixClient.

Notes: Add MatrixClient.checkIfOwnDeviceCrossSigned method, for checking if another of our devices is cross-signed regardless of whether this device trusts the MSK.


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@duxovni duxovni requested a review from a team as a code owner April 8, 2022 21:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #2288 (62d2d0e) into develop (f963fea) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop    #2288      +/-   ##
===========================================
+ Coverage    59.52%   59.54%   +0.01%     
===========================================
  Files           91       91              
  Lines        16412    16420       +8     
  Branches      3782     3783       +1     
===========================================
+ Hits          9770     9777       +7     
- Misses        6642     6643       +1     
Impacted Files Coverage Δ
src/client.ts 37.82% <75.00%> (+0.06%) ⬆️
src/crypto/index.ts 64.43% <100.00%> (+0.10%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants