Update the release process to use github releases #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbkr
commented
Nov 1, 2016
dbkr
commented
- Removes the 'dist' directory from the source tree, as it's a little strange keeping built artefacts from every version in the master branch.
- Build release assets at release time using the 'dist' script
- Use 'hub' to perform the actual release (ie. make the tag, except that it also uploads release assets)
Rather than to version specific directories beneath dist, since we're now not keeping every built version in the source tree. Also: * build the minified version at the same time, * Include rimraf so we can rm -r dist (npm has re-ordered the deps) * Exclude olm from the bundled file
and gitignore dist since we now just use it for build output.
Adds the 'dist' target for building assets for distribution, which the release script will run, uploading resulting files as release assets.
(which just runs npm build, but the presence of the dist script will inform the release process to run it and upload release assets)
richvdh
reviewed
Nov 1, 2016
| @@ -6,7 +6,7 @@ coverage | |||
| lib-cov | |||
| out | |||
| reports | |||
| dist/browser-matrix-dev.js | |||
| dist | |||
| your page. There will be a global variable ``matrixcs`` attached to | ||
| ``window`` through which you can access the SDK. | ||
| Download either the full or minified version from | ||
| https://github.com/dbkr/test/releases/latest and add that as a ``<script>`` to |
There was a problem hiding this comment.
what's the plan with dbkr/test ? Fix this after release?
| prerelease=0 | ||
| # We check if this build is a prerelease by looking to | ||
| # see if the version has a hyphen in it. Crude, | ||
| # but semver doesn't support postreleaseses so anything |
| Unreleased changes | ||
| ================== | ||
|
|
||
| Breaking Changes |
There was a problem hiding this comment.
Not convinced that's a breaking change, reallly.
There was a problem hiding this comment.
Yeah, it's not an API change, I erred on the side of caution and put it in just in case anyone is depending on them being in that place. wdyt?
|
ptal |
Rather than trying to use them and failing at annoying points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.