Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more typescript --strict violations #2795

Merged
merged 11 commits into from
Oct 25, 2022
Merged

Fix more typescript --strict violations #2795

merged 11 commits into from
Oct 25, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 24, 2022 •
edited by github-actions bot
Loading

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy changed the title Stash tsc fixes Fix more typescript --strict violations Oct 24, 2022
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 24, 2022
@t3chguy t3chguy marked this pull request as ready for review October 25, 2022 09:31
@t3chguy t3chguy requested a review from a team as a code owner October 25, 2022 09:31
SimonBrandner
SimonBrandner approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/models/event-context.ts Show resolved Hide resolved
spec/unit/event.spec.ts Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Oct 25, 2022

Bypassing coverage requirement due to the nature of this PR

@t3chguy t3chguy merged commit 9f2f08d into develop Oct 25, 2022
@t3chguy t3chguy deleted the t3chguy/tsc-strict3 branch October 25, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @SimonBrandner