Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore random macOS crap (.DS_Store) #2851

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Ignore random macOS crap (.DS_Store) #2851

merged 1 commit into from
Nov 4, 2022

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 4, 2022 •
edited
Loading

Ignore random macOS crap (.DS_Store)

Accidentally merged with #2848

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods MadLittleMods added the T-Task Tasks for the team like planning label Nov 4, 2022
@MadLittleMods MadLittleMods marked this pull request as ready for review November 4, 2022 11:00
@MadLittleMods MadLittleMods requested a review from a team as a code owner November 4, 2022 11:00
weeman1337
weeman1337 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Though, I would prefer to keep personal dev environment specifics in a global gitignore on the dev machine itself.

@MadLittleMods MadLittleMods merged commit 38adbaf into develop Nov 4, 2022
@MadLittleMods MadLittleMods deleted the madlittlemods/ignore-ds-store branch November 4, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@t3chguy t3chguy t3chguy approved these changes

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MadLittleMods @t3chguy @weeman1337