Use a temporary Git dependency instead of patch-package #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch-package is only designed for use in top-level applications, not in libraries which get repackaged, and so will fail to run in upstream consumers of matrix-js-sdk. Until the issues with matrix-events-sdk are resolved, this replaces the patch-package workaround with a temporary Git dependency to unblock upstream packages such as Element Call, while keeping the typechecker happy.
|
Well, this doesn't work either |
|
I've checked the build artifacts for matrix-events-sdk into a fork, which seems to have worked (but feels very wrong) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch-package is only designed for use in top-level applications, not in libraries which get repackaged, and so will fail to run in upstream consumers of matrix-js-sdk. Until the issues with matrix-events-sdk are resolved, this replaces the patch-package workaround with a temporary Git dependency to unblock upstream packages such as Element Call, while keeping the typechecker happy.
Notes: none
This change has no change notes, so will not be included in the changelog.