Avoid a packetstorm of device queries on startup #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two main changes here: * when we get an m.new_device event for a device we know about, ignore it * Batch up the m.new_device events received during initialsync and spam out all the queries at once.
| return this._baseApis.downloadKeysForUsers( | ||
| var r = this._doKeyDownloadForUsers(downloadUsers); | ||
| var promises = []; | ||
| downloadUsers.map(function(u) { |
There was a problem hiding this comment.
Should this be map or should it be forEach?
There was a problem hiding this comment.
Array.forEach doesn't exist pre-ES5, and I don't think we have a polyfill for it. Is there a reason to avoid map ?
There was a problem hiding this comment.
Nope, map is fine, was just curious.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes here:
This fixes element-hq/element-web#2274.
It also removes EncryptionAlgorithm.onNewDevice, so will break develop unless
#295 is landed.