Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'qs' dependency #3033

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Remove 'qs' dependency #3033

merged 1 commit into from
Jan 6, 2023

Conversation

clarkf
Copy link
Contributor

@clarkf clarkf commented Jan 5, 2023

'qs' (package, source) appears to be unused since 34c5598 (PR #2719), and can be safely removed.

It's worth noting that 'qs' has the deepest dependency graph of all (non-development) dependencies.

$ npm ls --depth=32 --omit=dev
...
├─┬ [email protected]
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ ├── [email protected]
│   │ └── [email protected] deduped
│   ├─┬ [email protected]
│   │ ├── [email protected] deduped
│   │ ├── [email protected]
│   │ └─┬ [email protected]
│   │   └── [email protected] deduped
│   └── [email protected]
...

No other dependencies have more than one level of nesting.

#244 is relevant here (maybe?), though this doesn't go particularly far. A full dev install still weighs 372M on my machine, though this reduces a production install from 9.3M to 8.6M.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@clarkf clarkf requested a review from a team as a code owner January 5, 2023 23:13
@clarkf clarkf requested a review from turt2live January 5, 2023 23:13
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 5, 2023
@turt2live turt2live added the T-Task Tasks for the team like planning label Jan 6, 2023
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like we indeed don't use this dependency.

Just one comment about the lockfile before we can merge this.

yarn.lock Outdated Show resolved Hide resolved
'qs' appears to be unused since 34c5598 (PR matrix-org#2719).

Signed-off-by: Clark Fischer <[email protected]>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants