Update release script to do signed releases #305
Conversation
if a signing ID is set in release_config.yaml Also set the release text to the relevant changelog entry
| @@ -145,21 +153,43 @@ if [ $dodist -eq 0 ]; then | |||
| # We haven't tagged yet, so tell the dist script what version | |||
| # it's building | |||
| DIST_VERSION="$tag" npm run dist | |||
|
|
|||
| `dirname $0`/scripts/changelog_head.py > latest_changes.md | |||
There was a problem hiding this comment.
this looks like it won't work because of the pushd "$builddir"?
There was a problem hiding this comment.
Also, where is changelog_head.py?
There was a problem hiding this comment.
Oops, added changelog_head. And yeah, this should work since it's taking the path the script itself is executed with (which will be node_modules/matrix-js-sdk/ because of https://github.com/vector-im/riot-web/blob/master/release.sh#L12) and executing changelog_head relative to that
There was a problem hiding this comment.
except that at this point you are in the build dir, so node_modules won't be found
There was a problem hiding this comment.
Right, I believe this works now.
| @@ -145,21 +153,43 @@ if [ $dodist -eq 0 ]; then | |||
| # We haven't tagged yet, so tell the dist script what version | |||
| # it's building | |||
| DIST_VERSION="$tag" npm run dist | |||
|
|
|||
| `dirname $0`/scripts/changelog_head.py > latest_changes.md | |||
There was a problem hiding this comment.
are we doing anything here to ensure that the riot-web changelog references or links to the equivalent matrix-react-sdk changelog (and similarly js-sdk changelog)? At the least, we might want to include non-versioned links to the latest_changes for those projects. And slightly better would be links to the right version of latest_changes for the deps...
There was a problem hiding this comment.
The release script is common to js-sdk and react-sdk though, and this would all be riot-web specific logic to insert js-sdk and react-sdk changelogs.
|
lgtm modulo comments, assuming it works :D |
so we know the relative path is right
if a signing ID is set in release_config.yaml
Also set the release text to the relevant changelog entry