Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build process for ES6 #320

Merged
merged 10 commits into from
Jan 12, 2017
Merged

Update build process for ES6 #320

merged 10 commits into from
Jan 12, 2017

Commits on Jan 11, 2017

  1. Update build process for ES6

     * Make npm run build run npm compile (it needs the output)
     * Switch to ESlint so we can actually use ES6 without the linter
       crying.
    dbkr committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    9b5cb3a View commit details
    Browse the repository at this point in the history
  2. Merge compile target into build

    dbkr committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    0dfd60a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2017

  1. Add exceptions to eslintrc for JSDoc

    To allow things we've been OK about previously
    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    ff72398 View commit details
    Browse the repository at this point in the history
  2. Fix legitimate JSDoc errors

    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    0a11404 View commit details
    Browse the repository at this point in the history
  3. Fix jsdoc errors in spec/

    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    31af4bb View commit details
    Browse the repository at this point in the history
  4. Lint spec as well as src

    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    7f8375d View commit details
    Browse the repository at this point in the history
  5. it's build now, not compile

    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    591b56d View commit details
    Browse the repository at this point in the history
  6. Run lint on prepublish, not build

    and make everything errors, so now you can do local builds with
    lint failures, but CI will fail and you can't release.
    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    543b9cf View commit details
    Browse the repository at this point in the history
  7. Add google eslint rules as a base

    Remove some we don't care about. Set some other ones we do care
    about but don't currently adhere to to warn. Set the max warnings
    threshold to the current number of warnings, so we don't introduce
    more of them. Fix a bunch of legit lint errors and add exceptions
    to various places in the test code that does funny things with
    'this'.
    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    e057956 View commit details
    Browse the repository at this point in the history
  8. Add eslint:recommends

    Turn off / tweak some options from it. Fix a double-definition.
    Add an eslint config to the spec directory to tell it about the
    jasmine magic globals.
    dbkr committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    4ab261b View commit details
    Browse the repository at this point in the history