Split up, rename, and move ISecretStorageKeyInfo
#3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/refactor_secret_storage/cleanup_descriptors
branch
from
d1f27ec
to
d711ed4
Compare
richvdh
force-pushed
the
rav/refactor_secret_storage/cleanup_descriptors
branch
from
d711ed4
to
480eeab
Compare
t3chguy
approved these changes
Mar 31, 2023
weeman1337
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Move SecretStorageKeyInfo interfaces out to a new module * Replace usages of ISecretStorageKeyInfo with SecretStorageKeyDescription
weeman1337
added a commit
that referenced
this pull request
Apr 6, 2023
* Retry processing potential poll events after decryption * Point `typedoc` at `matrix.ts`, not `index.ts` (#3239) This gets rid of the rather pointless "default" module in the generated docs. * Split up, rename, and move `ISecretStorageKeyInfo` (#3242) * Move SecretStorageKeyInfo interfaces out to a new module * Replace usages of ISecretStorageKeyInfo with SecretStorageKeyDescription * Skip clear text non-poll events --------- Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface currently:
IThis PR attempts to solve all three problems, by splitting the class up, renaming it, and moving it.
The old name is still exported for backwards compatibility.
This is the first step part of a larger piece of work in refactoring the SecretStorage interface (element-hq/element-web#24982)
This change is marked as an internal change (Task), so will not be included in the changelog.