Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen sharing on Firefox 113 #3282

Merged

Conversation

tulir
Copy link
Member

@tulir tulir commented Apr 13, 2023

getCapabilities exists now(?), but setCodecPreferences doesn't, which means it would throw an error and fail the call.


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix screen sharing on Firefox 113 (#3282). Contributed by @tulir.

`getCapabilities` exists now(?), but `setCodecPreferences` doesn't,
which means it would throw an error and fail the call.

Signed-off-by: Tulir Asokan <[email protected]>
@tulir tulir requested a review from a team as a code owner April 13, 2023 20:37
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 13, 2023
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@SimonBrandner SimonBrandner added this pull request to the merge queue Apr 15, 2023
Merged via the queue into matrix-org:develop with commit 87398ac Apr 15, 2023
texuf pushed a commit to texuf/matrix-js-sdk that referenced this pull request Apr 17, 2023
`getCapabilities` exists now(?), but `setCodecPreferences` doesn't,
which means it would throw an error and fail the call.

Signed-off-by: Tulir Asokan <[email protected]>
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 25, 2023
* Change `Store.save()` to return a `Promise` ([\matrix-org#3221](matrix-org#3221)). Contributed by @texuf.
* Add typedoc-plugin-mdn-links ([\matrix-org#3292](matrix-org#3292)).
* Annotate events with executed push rule ([\matrix-org#3284](matrix-org#3284)). Contributed by @kerryarchibald.
* Element-R: pass device list change notifications into rust crypto-sdk ([\matrix-org#3254](matrix-org#3254)). Fixes element-hq/element-web#24795. Contributed by @florianduros.
* Support for MSC3882 revision 1 ([\matrix-org#3228](matrix-org#3228)). Contributed by @hughns.
* Fix screen sharing on Firefox 113 ([\matrix-org#3282](matrix-org#3282)). Contributed by @tulir.
* Retry processing potential poll events after decryption ([\matrix-org#3246](matrix-org#3246)). Fixes element-hq/element-web#24568.
* Element-R: handle events which arrive before their keys ([\matrix-org#3230](matrix-org#3230)). Fixes element-hq/element-web#24489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants