Factor out device list management #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto/index.js was getting huge, so move the device list update management out to a separate file. This shouldn't have any effect on functionality.
ara4n
reviewed
Feb 2, 2017
src/crypto/DeviceList.js
Outdated
| @@ -0,0 +1,446 @@ | |||
| /* | |||
| Copyright 2017 OpenMarket Ltd | |||
There was a problem hiding this comment.
we were OpenMarket when I wrote it ;). Will fix.
ara4n
reviewed
Feb 2, 2017
| } | ||
| const res = []; | ||
| for (const deviceId in devs) { | ||
| if (devs.hasOwnProperty(deviceId)) { |
There was a problem hiding this comment.
bit of a shame that we're doing a weird hybrid of const and then horrid hasOwnProperty crap. but this can be fixed up in a later hygiene pass.....
There was a problem hiding this comment.
yeah, this was deliberately an airlift of the code to another file with absolutely minimal changes.
|
this LGTM - massive improvement, if only for gathering that stuff into one place rather than dotting it around in crypto/index.js |
ara4n
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto/index.js was getting huge, so move the device list update management out
to a separate file.
This shouldn't have any effect on functionality.