Use stricter types on login functions #3482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2023 16:52
3 tasks
artcodespace
approved these changes
Jun 16, 2023
| }; | ||
| } | ||
| return response; | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * @returns Promise which resolves: TODO |
There was a problem hiding this comment.
Is the TODO relating to the type it returns? Not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21967
Pulling the loose string from strictification work in
AddThreepidI found these untyped functions.There is some distance between the spec and js-sdk's current implementation, for example the login type "m.login.saml2"
Breaking as far as types, no changes to logic.
With matrix-org/matrix-react-sdk#11101
Checklist
Here's what your changelog entry will look like:
🚨 BREAKING CHANGES