Element-R: Implement VerificationRequest.accept
#3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs matrix-org/matrix-rust-sdk#2177 to pass the tests |
Base automatically changed from
rav/element-r/32_emit_request_received
to
develop
June 28, 2023 14:49
richvdh
force-pushed
the
rav/element-r/33_accept_request
branch
from
f440461
to
7a1ddec
Compare
... so that the application can later call `accept()` and we know what to send.
richvdh
force-pushed
the
rav/element-r/33_accept_request
branch
from
7a1ddec
to
1b8c1ca
Compare
artcodespace
approved these changes
Jun 30, 2023
richvdh
commented
Jun 30, 2023
Comment on lines
+1430
to
+1432
| version "0.1.0" | ||
| resolved "https://registry.yarnpkg.com/@matrix-org/matrix-sdk-crypto-js/-/matrix-sdk-crypto-js-0.1.0.tgz#766580036d4df12120ded223e13b5640e77db136" | ||
| integrity sha512-ra/bcFdleC1iRNms2I96UXA0NvQYWpMsHrV5EfJRS7qV1PtnQNvgsvMfjMbkx8QT2ErEmIhsvB5fPCpfp8BSuw== |
There was a problem hiding this comment.
0.1.0 fixes a bug in cancellation which you'll likely never notice unless you happen to be an integration test
t3chguy
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#25320
Based on #3528This change is marked as an internal change (Task), so will not be included in the changelog.