Bump pagination limit to account for threaded events #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Looks good, same question as in matrix-org/matrix-react-sdk#11342 regarding the timing difference between the two calls.
|
@germain-gg this isn't modifying any calls - just changing how many calls we make before giving up on pagination. This code was made before threads and hidden events were a thing. Both of those can make us give up on pagination when there is actual history to find. So no per-call timing change, just the potential for more calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#25873
Here's what your changelog entry will look like:
✨ Features