Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport staging] Fix screen sharing in recent Chrome #4243

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[Backport staging] Fix screen sharing in recent Chrome #4243

merged 1 commit into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Fix screen sharing in recent Chrome (#4241) 

    * Fix screen sharing in recent Chrome

Dreadful hack to work around a bug in recent chrome/electron's
WebRTC, as explained.

I'm not sure which is the least hideous out of this (ie. repeatedly
calling setCodecPreferences and seeing if it crashes each time) or
hardcoding the bad codec and skipping it. Opinions welcome.

* Unused import

* Remove commented line

(cherry picked from commit 9218f63)
    @dbkr @github-actions
    dbkr authored and github-actions[bot] committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0f600e1 View commit details
    Browse the repository at this point in the history