Add in a public api getStoredDevice allowing clients to get a specific device #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
requested changes
May 21, 2017
src/client.js
Outdated
| * @param {string} userId the user to list keys for. | ||
| * @param {string} deviceId unique identifier for the device | ||
| * | ||
| * @return {module:crypto-deviceinfo} device or nothing |
There was a problem hiding this comment.
since its nullable it should be
@return {?module:crypto-deviceinfo} device or null
There was a problem hiding this comment.
Whoops, okay. Will update comment!
kscz
force-pushed
the
add_getstoreddeviceforuser
branch
from
e0471f6
to
6443ad1
Compare
…c device Signed-off-by: Kit Sczudlo <[email protected]>
kscz
force-pushed
the
add_getstoreddeviceforuser
branch
from
6443ad1
to
822380a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
crypto.getStoredDevice(userId, deviceId)api publically