Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCSession cleanup: deprecate getKeysForParticipant() and getEncryption(); add emitEncryptionKeys() #4427

Merged
merged 5 commits into from
Sep 27, 2024
Merged

RTCSession cleanup: deprecate getKeysForParticipant() and getEncryption(); add emitEncryptionKeys() #4427

merged 5 commits into from
Sep 27, 2024
+98 −31

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 23, 2024 •
edited
Loading

This is an "alternative" to #4423 which cleans up the RTCSession API instead.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns changed the title RTCSession cleanup: deprecate getKeysForParticipant() and getEncrypti… RTCSession cleanup: deprecate getKeysForParticipant() and getEncryption(); add emitEncryptionKeys() Sep 23, 2024
@hughns hughns added the T-Deprecation A pull request that makes something deprecated label Sep 23, 2024
@hughns hughns marked this pull request as ready for review September 23, 2024 16:32
@hughns hughns requested a review from a team as a code owner September 23, 2024 16:32
@hughns hughns mentioned this pull request Sep 23, 2024
Closed
4 tasks
AndrewFerr
AndrewFerr reviewed Sep 23, 2024
View reviewed changes
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
AndrewFerr
AndrewFerr approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a nitpick on a docstring 🙂

src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
@hughns hughns added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit baa6d13 Sep 27, 2024
26 checks passed
@hughns hughns deleted the hughns/matrixrtc-encryption-api-cleanup branch September 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughns @AndrewFerr