Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatrixRTCSession: handle rate limit errors #4494

Merged
merged 7 commits into from
Nov 11, 2024
Merged

MatrixRTCSession: handle rate limit errors #4494

merged 7 commits into from
Nov 11, 2024

Conversation

AndrewFerr
Copy link
Member

Depends on:

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr requested review from a team as code owners November 1, 2024 16:15
@t3chguy t3chguy changed the base branch from develop to af/widget-errors November 1, 2024 16:21
toger5
toger5 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew. This part looks straight forward.

@AndrewFerr AndrewFerr mentioned this pull request Nov 7, 2024
Merged
4 tasks
Base automatically changed from af/widget-errors to develop November 9, 2024 07:46
@AndrewFerr
MatrixRTCSession: handle rate limit errors
133995c
@AndrewFerr
Lint
473c3cc
@AndrewFerr
Handle ratelimiting for non-legacy state setting
b96ae12 
Each request must be retried, as the non-legacy flow involves a sequence
of requests that must resolve in order.
robintown added a commit to robintown/element-call that referenced this pull request Nov 9, 2024
@robintown
Bump matrix-js-sdk and matrix-widget-api
ca63035 
This bumps matrix-js-sdk to a preview branch that includes matrix-org/matrix-js-sdk#4498 and matrix-org/matrix-js-sdk#4494, and matrix-widget-api to 1.10.0.
@robintown robintown mentioned this pull request Nov 9, 2024
Merged
@AndrewFerr AndrewFerr added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 10a4fd8 Nov 11, 2024
26 checks passed
@AndrewFerr AndrewFerr deleted the af/rtc-handle-ratelimiting branch November 11, 2024 03:12
hughns added a commit to element-hq/element-call that referenced this pull request Nov 11, 2024
@hughns
Bump js-sdk
00765e8 
matrix-org/matrix-js-sdk@6971e7b...fcb69b1

Also brings in:

- matrix-org/matrix-js-sdk#4342
- matrix-org/matrix-js-sdk#4494
@hughns hughns mentioned this pull request Nov 11, 2024
Merged
hughns added a commit to element-hq/element-call that referenced this pull request Nov 11, 2024
@hughns
Add matrix_rtc_session config options + bump js-sdk (#2756)
8be6655 
* Add matrix_rtc_session config options
* Bump js-sdk

matrix-org/matrix-js-sdk@6971e7b...fcb69b1

Also brings in:

- matrix-org/matrix-js-sdk#4342
- matrix-org/matrix-js-sdk#4494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewFerr @t3chguy @toger5