Inspect the state of the timeline to possibly resolve with less event loops in theory #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent loop If we already have a timeline for an event, don't do an async call, just use the timeline found directly.
|
This is a more stable/nicer fix but the result is the same. Let's consider merging once the release is out the door. |
|
this doesn't seem to be happening, and has now bitrotted. let's close it for now at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we already have a timeline for an event, don't do an async call, just use the timeline found directly.
This is the alternative to #458 which will immediately check if a promise is resolved.
Instead, this patch will check if there is a timeline for the event synchronously and then use that to instantiate the timeline window.