Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix early return in MatrixClient.setGuestAccess #487

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Fix early return in MatrixClient.setGuestAccess #487

merged 1 commit into from
Jul 11, 2017

Commits on Jul 10, 2017

  1. Fix early return in MatrixClient.setGuestAccess 

    (as well as a similar bug in the test suite)

Turns out that `q.all(a, b)` === `q.all([a])`, rather than `q.all([a,b])`: it
only waits for the *first* promise - which means that `client.setGuestAccess`
would swallow any errors returned from the API.
    @richvdh
    richvdh committed Jul 10, 2017
    Configuration menu
    Copy the full SHA
    9558845 View commit details
    Browse the repository at this point in the history