Yet more js-sdk test deflakification #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These guys do a flush("/sync"), without waiting for it to complete, and then in
the afterEach, check that the sync has been flushed, which it may not have
been. So we should make sure we wait for the flush.
Waiting for 1ms isn't actually good enough. wait for the actual thing we are actually waiting for.
All that crypto stuff takes a while, so give it longer than 100ms.
| done(); | ||
|
|
||
| // still have a sync to flush | ||
| httpBackend.flush("/sync", 1).then(() => { |
There was a problem hiding this comment.
I'm not sure why this has to flush immediately before calling done, likewise for other parts of this test
There was a problem hiding this comment.
See the commit comment (adca75b): the afterEach checks it's been flushed.
There was a problem hiding this comment.
I'm not sure the afterEach should be used for that, should it not just kill the httpBackend altogether?
There was a problem hiding this comment.
We decided (via https://riot.im/develop/#/room/#riot-dev:matrix.org/$1500047765866CodIk:sw1v.org) to leave that discussion for another day.
lukebarnard1
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a version of matrix-mock-request including matrix-org/matrix-mock-request#5, so this won't build yet.